To: vim_dev@googlegroups.com
Subject: Patch 8.2.0510
Fcc: outbox
From: Bram Moolenaar <Bram@moolenaar.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
------------

Patch 8.2.0510
Problem:    Coverity complains about using uninitialized variable.
Solution:   Assign a value to "scol".  Move code inside NULL check.
Files:      src/beval.c, src/popupwin.c


*** ../vim-8.2.0509/src/beval.c	2019-11-30 22:40:44.000000000 +0100
--- src/beval.c	2020-04-04 14:47:28.248431226 +0200
***************
*** 110,115 ****
--- 110,117 ----
  			lbuf = vim_strnsave(lbuf, len);
  		    }
  		}
+ 		else
+ 		    scol = col;
  
  		if (winp != NULL)
  		    *winp = wp;
*** ../vim-8.2.0509/src/popupwin.c	2020-04-02 18:50:42.423773112 +0200
--- src/popupwin.c	2020-04-04 14:49:39.855963305 +0200
***************
*** 798,813 ****
  		    if (*str != NUL)
  			wp->w_border_char[i] = mb_ptr2char(str);
  		}
! 	    }
! 	    if (list->lv_len == 1)
! 		for (i = 1; i < 8; ++i)
! 		    wp->w_border_char[i] = wp->w_border_char[0];
! 	    if (list->lv_len == 2)
! 	    {
! 		for (i = 4; i < 8; ++i)
! 		    wp->w_border_char[i] = wp->w_border_char[1];
! 		for (i = 1; i < 4; ++i)
! 		    wp->w_border_char[i] = wp->w_border_char[0];
  	    }
  	}
      }
--- 798,813 ----
  		    if (*str != NUL)
  			wp->w_border_char[i] = mb_ptr2char(str);
  		}
! 		if (list->lv_len == 1)
! 		    for (i = 1; i < 8; ++i)
! 			wp->w_border_char[i] = wp->w_border_char[0];
! 		if (list->lv_len == 2)
! 		{
! 		    for (i = 4; i < 8; ++i)
! 			wp->w_border_char[i] = wp->w_border_char[1];
! 		    for (i = 1; i < 4; ++i)
! 			wp->w_border_char[i] = wp->w_border_char[0];
! 		}
  	    }
  	}
      }
*** ../vim-8.2.0509/src/version.c	2020-04-04 14:00:34.197098267 +0200
--- src/version.c	2020-04-04 14:50:00.063891507 +0200
***************
*** 740,741 ****
--- 740,743 ----
  {   /* Add new patch number below this line */
+ /**/
+     510,
  /**/

-- 
BRIDGEKEEPER: What is your favorite editor?
GAWAIN:       Emacs ...  No, Viiiiiiiiiiimmmmmmm!
           "Monty Python and the Holy editor wars" PYTHON (MONTY) SOFTWARE LTD

 /// Bram Moolenaar -- Bram@Moolenaar.net -- http://www.Moolenaar.net   \\\
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\  an exciting new programming language -- http://www.Zimbu.org        ///
 \\\            help me help AIDS victims -- http://ICCF-Holland.org    ///