To: vim_dev@googlegroups.com Subject: Patch 8.1.2334 Fcc: outbox From: Bram Moolenaar Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ------------ Patch 8.1.2334 Problem: Possible NULL pointer dereference in popup_locate(). (Coverity) Solution: Check for NULL pointer. Files: src/popupwin.c *** ../vim-8.1.2333/src/popupwin.c 2019-11-16 20:03:27.405056583 +0100 --- src/popupwin.c 2019-11-22 19:14:35.878137660 +0100 *************** *** 2599,2605 **** win_T *wp; wp = mouse_find_win(&row, &col, FIND_POPUP); ! if (WIN_IS_POPUP(wp)) rettv->vval.v_number = wp->w_id; } --- 2599,2605 ---- win_T *wp; wp = mouse_find_win(&row, &col, FIND_POPUP); ! if (wp != NULL && WIN_IS_POPUP(wp)) rettv->vval.v_number = wp->w_id; } *** ../vim-8.1.2333/src/version.c 2019-11-21 23:23:56.671658025 +0100 --- src/version.c 2019-11-22 19:21:37.240156197 +0100 *************** *** 739,740 **** --- 739,742 ---- { /* Add new patch number below this line */ + /**/ + 2334, /**/ -- hundred-and-one symptoms of being an internet addict: 105. When someone asks you for your address, you tell them your URL. /// Bram Moolenaar -- Bram@Moolenaar.net -- http://www.Moolenaar.net \\\ /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org /// \\\ help me help AIDS victims -- http://ICCF-Holland.org ///